CPUID dump check test case #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This adds a new test function to the cpuid.py test module, where the CPUID data exposed by QEMU is compared with a full CPUID dump extracted previously. The new test code ensures that there are no ABI changes for a given machine-type + CPU model combination, between QEMU versions. The reference dumps were generated using the build-qemu-and-dump-cpus, and copied using the copy-ref-dumps script. There are some known QEMU bugs and past ABI changes that require ignoring some differences. Those cases handled as rules that set ignore_cpuid_leaves on qemu_cpu.cfg. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
| """ | ||
| Compare full CPUID dump data | ||
| """ | ||
| machine_type = params.get("machine_type_to_check","") |
There was a problem hiding this comment.
This will have the same result as you expect:
machine_type = params['machine_type_to_check']
This is a new params feature :)
There was a problem hiding this comment.
Yes, if you write this as @ypu mentioned, you don't have to manually throw error.TestNAError as you did here, the params class will take care of throwing an exception based on TestNAError.
|
Pushed to next, as the comments made are pretty minor and can be changed on a follow up patch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new test function to the cpuid.py test module, where the
CPUID data exposed by QEMU is compared with a full CPUID dump extracted
previously.
The new test code ensures that there are no ABI changes for a given
machine-type + CPU model combination, between QEMU versions.
There are some known QEMU bugs and past ABI changes that require
ignoring some differences. Those cases handled as rules that set
ignore_cpuid_leaves on qemu_cpu.cfg.