Several bugfixes #36
Merged
Several bugfixes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize it with spaces instead.
Depending on locale, the formatted date and time may not fit in the allocated time_string buffer, e.g. when the time zone is also included. Since the allocation is short-lived anyway, a somewhat larger buffer size was chosen.
The function g_ascii_strdown allocates a new char array to return, so the one passed in as argument should be freed afterwards if it isn't used.
The double call to lround with an assignment in the middle was simplified to a single call to lround as this produces identical results on gcc, but now clang also produces the same results which it did not do before.
This is in line with libpng's documentation for taking the low-level API approach which the rest of the function is doing. Using png_read_png results in a crash on my machine.
This caused the preserve width option to have no effect, because it never matched with the misspelled version.
Probably more bounds checks are needed, but this one is surely triggered because is_valid_dir is called with row and col up to height-1 and width-1 respectively with dir=EAST in find_centerline_pixels at src/pxl-outline.c:243 (after commit).
There's an array with a fixed length, its maximum index should be lower than that length, otherwise a fatal error is now triggered.
|
@martweb1 can this be merged? |
|
Hopefully yes, don't know why other people further developed AutoTrace without any information to me. Otherwise I could have coordinate it.
…
Am 15.08.2020 in 18:51, Matthew McMillan ***@***.***> schrieb:
@martweb1 can this be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Not sure about the other changes, but I'm successfully using this branch to work around the "invalid chunk type" error. Thanks! Any update on this being merged? |
|
I'm also having trouble with this 'chunk' error. It would be great if this fix could be merged now. |
|
@lemenkov Are you still in charge of this repository? |
|
I believe @jnweiger is the other member of the repository. If you could take a look and merge this PR that would be great! |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bundle of several unrelated bugfixes, the commit messages describe what each commit should fix. Commit 9974cb0 fixes the "invalid chunk type" error for png input referenced in #5 and #34 but in a different way than the patches in #15 because I had not seen those yet when I wrote it.