Remove redundant menu icon which did nothing

In narrow viewports, a menu button was visible which had no behaviour associated with it. I believe this was intended to show the menu which is hidden on narrow viewports. We don't really use the menu at the moment as we don't have other pages. This may be more important if we introduce more pages into the blog, for example a video page. I've created a `menu-button-present-but-inactive` branch with these pages and issue #2 representing the fact that in narrow screens there will be no way to see the menu.
autotraderuk · Jan 17, 2024 · 1f5288d · 1f5288d
1 parent 9f1a87e
commit 1f5288d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 36 deletions.
diff --git a/_includes/header.html b/_includes/header.html
@@ -18,18 +18,6 @@
         <nav class="site-nav">
 
 
-            <a href="#" class="menu-icon" data-track="menu button">
-                <svg viewBox="0 0 18 15">
-                    <path fill="#424242" d="M18,1.484c0,0.82-0.665,1.484-1.484,1.484H1.484C0.665,2.969,0,2.304,0,1.484l0,0C0,0.665,0.665,0,1.484,0 h15.031C17.335,0,18,0.665,18,1.484L18,1.484z"/>
-                    <path fill="#424242" d="M18,7.516C18,8.335,17.335,9,16.516,9H1.484C0.665,9,0,8.335,0,7.516l0,0c0-0.82,0.665-1.484,1.484-1.484 h15.031C17.335,6.031,18,6.696,18,7.516L18,7.516z"/>
-                    <path fill="#424242" d="M18,13.516C18,14.335,17.335,15,16.516,15H1.484C0.665,15,0,14.335,0,13.516l0,0 c0-0.82,0.665-1.484,1.484-1.484h15.031C17.335,12.031,18,12.696,18,13.516L18,13.516z"/>
-                </svg>
-            </a>
-
-
-
-
-
             <a class="site-title at-logo" href="{{ '' | relative_url }}/" data-track="nav AT logo" >
                 Auto Trader
             </a>

diff --git a/_sass/_layout.scss b/_sass/_layout.scss
@@ -27,10 +27,6 @@
         padding: 0;
     }
 
-    .menu-icon {
-        display: none;
-    }
-
     .page-link {
         color: $at-white;
         line-height: $base-line-height;
@@ -45,26 +41,6 @@
         line-height: 0;
         padding-top: 5px;
 
-        .menu-icon {
-            display: block;
-            float: right;
-            width: 36px;
-            min-height: 26px;
-
-            text-align: center;
-
-            > svg {
-                width: 18px;
-                height: 15px;
-                margin-top: 2px;
-
-
-                path {
-                    fill: $at-white;
-                }
-            }
-        }
-
         .trigger {
             clear: both;
             display: none;