Replies: 5 comments 2 replies
-
Click here to expand (You can ignore this)Github provides free action runners. But they are also limited in numbers. For free plan, per organization, they provide 20 concurrent jobs. And autoware.universe is just one of the many repositories within the organization.
But when we have so many heavy tasks like:
These add up and clog up the resources, preventing even small jobs from running. I understand it would be great if we could run this job per PR but if it is slow like this, it won't be possible. We should either:
Never mind, I was looking at total workflow time, the |
Beta Was this translation helpful? Give feedback.
-
I modified the rulesets to make it required. |
Beta Was this translation helpful? Give feedback.
-
Memo: There was an issue in comparing the current branch and the main branch, especially when the PR branch is not up-to-date with the main branch. We should modify here to address this issue: https://github.com/autowarefoundation/autoware.universe/blob/afc129e98554c1499a80862f6f27235154059c23/.github/workflows/cppcheck-differential.yaml#L32-L37 |
Beta Was this translation helpful? Give feedback.
-
@kminoda |
Beta Was this translation helpful? Give feedback.
-
We have fixed the issue discussed above in this PR !!
Could you make the |
Beta Was this translation helpful? Give feedback.
-
Introduction
To improve the code quality of Autoware Universe, we have introduced cppcheck, a static analysis tool, into our CI workflow. I would like to propose making cppcheck-differential a required check.
cppcheck Workflows
We have set up two workflows:
cppcheck-differential: This workflow checks only the minimal set of items and is intended to be a MUST-pass check. If there are no objections, we plan to make this workflow required.
cppcheck-all: This workflow checks all items in cppcheck and is intended to gradually reduce the number of issues to zero. This workflow is for informational purposes.
How to Access the Results
You can download the results of both workflows from the Summary section at the bottom of the GitHub Actions execution results.
See https://github.com/autowarefoundation/autoware.universe/actions/runs/9383750313
Proposal
We propose making the cppcheck-differential workflow a required check in our CI pipeline to ensure the quality of our codebase. Below are the details:
Request for Feedback
If you have any comments or suggestions regarding this proposal, especially if you wish to increase or decrease the suppression list, please provide your feedback by 10th of June (next Monday).
Beta Was this translation helpful? Give feedback.
All reactions