Support additionalTextEdits field of CompletionItem

[euclio]

This is used by the Java language server to supply automatic imports on completion.

It should only edit the document once the completion is actually selected.

[autozimu]

Completion is handled by deoplete or NVM. I can definitely make a change in this plugin to pass down additionalTextEdits.

The bigger part of change will need to be done on deoplete or NVM part though.

[euclio]

According to the linked deoplete issue, Shougo would rather have the additional edits performed with the CompleteDone autocmd than in deoplete itself.

[DeltaEvo]

I'm trying to implement this and snippets support by using CompleteDone event, but i have some issues with this.
Like @Shougo said this cause issues with other plugins because I can't assume that the completion came from LanguageClient.
I have some ideas but I don't like them:

• If plugin is deoplete i can parse from menu attribute
• Add some recognisable characters in some fields for the completion item

I think the best for this feature is that deoplete and ncm add a global variable containing the source name of the last completion but i don't know if it's possible ( hello @roxma ) ?

[autozimu]

It's also my conern. Alternatively, it could be done by making PR for deoplete and NCM.

…

On Thu, Aug 17, 2017 at 04:48 David Duarte ***@***.***> wrote: I'm trying to implement this and snippets support by using CompleteDone event, but i have some issues with this. Like @Shougo <https://github.com/shougo> said this cause issues with other plugins because I can't assume that the completion came from LanguageClient. I have some ideas but I don't like them: - If plugin is deoplete i can parse from menu attribute - Add some recognisable characters in some fields for the completion item I think the best for this feature is that deoplete and ncm add a global variable containing the source name for the last completion but i don't know if it's possible ( hello @roxma <https://github.com/roxma> ) ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#85 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYt70fzzUZKKFYNIM9Jxd-vg2Oz7YNeks5sZCiWgaJpZM4Oybf5> .

[autozimu]

This plugin has exposed enough information and function to achieve this feature.

The extra integration work should be done and tracked at completion framework side. e.g., roxma/nvim-completion-manager#130