Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Homebrew on Linux (amd64 and aarch64) #21

Closed
porelli opened this issue Nov 4, 2022 · 2 comments · Fixed by #22
Closed

Support for Homebrew on Linux (amd64 and aarch64) #21

porelli opened this issue Nov 4, 2022 · 2 comments · Fixed by #22

Comments

@porelli
Copy link
Contributor

porelli commented Nov 4, 2022

Similar to #12

When adding the formula and installing the package, the system receives the MacOS binary that of course cannot be executed.

$ file /home/linuxbrew/.linuxbrew/Cellar/unison-fsmonitor/0.3.0/bin/unison-fsmonitor
/home/linuxbrew/.linuxbrew/Cellar/unison-fsmonitor/0.3.0/bin/unison-fsmonitor: Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE|HAS_TLV_DESCRIPTORS>

Do you have any plan to support different platforms/architecture?

Thanks!

@porelli
Copy link
Contributor Author

porelli commented Nov 14, 2022

I added support for Linux and macOS for both amd64 and aarch64 here:
https://github.com/porelli/homebrew-formulas
https://github.com/porelli/unison-fsmonitor

There is still some work to do, for example reduce the size of the Linux binaries, but the macOS M1 release should work.

To test:

brew install porelli/homebrew-formulas/unison-fsmonitor

I do not have a Mac M1 to test the release, any help would be appreciated

@porelli
Copy link
Contributor Author

porelli commented Nov 15, 2022

I tested a little bit the Linux releases and it seems like it's not working. However, I tried also the binary generated directly with cargo install unison-fsmonitor and it has similar size and still doesn't work. The binary causes a huge spike in CPU usage at the beginning and then it remains at a constant 10-15% holding unison to perform anything.
Interestingly, the tests are passing without raising errors.

@autozimu - I know you mentioned that it should work but I guess it has not been properly tested?

Meanwhile, I opened a pull request to include unison-fsmonitor in the unison bottle for Linux: Homebrew/homebrew-core#115779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant