Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blob): Blob<T> -> Blob<isize> #4

Merged
merged 3 commits into from
Oct 28, 2015
Merged

feat(blob): Blob<T> -> Blob<isize> #4

merged 3 commits into from
Oct 28, 2015

Conversation

MichaelHirn
Copy link
Member

BREAKING CHANGE: Blob is no longer generic. All its attributes now are requiering a signed value. This makes a Blob always usable for neural nets.

@GitCop
Copy link

GitCop commented Oct 28, 2015

There were the following issues with your Pull Request

  • Commit: e2189a1
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/autumnai/phloem

This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Oct 28, 2015

There were the following issues with your Pull Request

  • Commit: e2189a1
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/autumnai/phloem

This message was auto-generated by https://gitcop.com

1 similar comment
@GitCop
Copy link

GitCop commented Oct 28, 2015

There were the following issues with your Pull Request

  • Commit: e2189a1
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/autumnai/phloem

This message was auto-generated by https://gitcop.com

@MichaelHirn
Copy link
Member Author

@homu r+

@homu
Copy link
Collaborator

homu commented Oct 28, 2015

📌 Commit f2cdaa4 has been approved by MichaelHirn

@homu
Copy link
Collaborator

homu commented Oct 28, 2015

⌛ Testing commit f2cdaa4 with merge 984607e...

homu added a commit that referenced this pull request Oct 28, 2015
@homu
Auto merge of #4 - autumnai:develop, r=MichaelHirn
984607e 
feat(blob): Blob<T> -> Blob<isize>

BREAKING CHANGE: Blob is no longer generic. All its attributes now are requiering a signed value. This makes a Blob always usable for neural nets.
@homu
Copy link
Collaborator

homu commented Oct 28, 2015

☀️ Test successful - status

@homu homu merged commit f2cdaa4 into master Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelHirn @GitCop @homu