Insert Pictures https://github.com/autyzm-pg/friendly-plans/issues/145 #189
Conversation
|
please can someone tell me whats the issue? |
There was a problem hiding this comment.
Wow! Looks really impressive! We really appreciate your help, great job. Thank you! 👍
The build is failing because I also can't build application locally. With merge to your code come some issue that are breaking build.
I have some ideas:
- please revert gradle dependencies version to previous one - I checked that, it's working fine.
- look at contributing.md and try to apply guideline to your Android studio -> https://github.com/autyzm-pg/friendly-plans/wiki/How-to-install-the-Google-Style-Guide-settings-in-Android-Studio then CTRL + ALT + L will reformat your code to fix codacy standards
- look at codacy issues: https://www.codacy.com/app/autyzmpgprojectOrganization/friendly-plans/pullRequest?prid=1016152 - do you have access ?
If you have any problems please ask, we really appreciate your effort.
| * Created by shreya on 24/10/17. | ||
| */ | ||
|
|
||
| public class Utils { |
There was a problem hiding this comment.
Maybe rename it to PremissionService
There was a problem hiding this comment.
There is one more class named this way.
| public static boolean checkPermission(final Context context) | ||
| { | ||
| int currentAPIVersion = Build.VERSION.SDK_INT; | ||
| if(currentAPIVersion>=android.os.Build.VERSION_CODES.M) |
There was a problem hiding this comment.
Instead of adding dots in code, import this constants.
import android.os.Build.VERSION_CODES;
....
VERSION_CODES.M
| ActivityCompat.requestPermissions((Activity) context, new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE); | ||
| } | ||
| return false; | ||
| } else { |
There was a problem hiding this comment.
Why this 'elses' are required?
| if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) { | ||
| if(userChoosenTask.equals("Take Photo")) | ||
| cameraIntent(); | ||
| else if(userChoosenTask.equals("Choose from Library")) |
There was a problem hiding this comment.
It would be worth to change strings in userChoosenTask to be enum. Maybe enum with { CAMERA , GALLERY }
| else if(userChoosenTask.equals("Choose from Library")) | ||
| galleryIntent(); | ||
| } else { | ||
| //code for deny |
There was a problem hiding this comment.
for that moment else can be removed.
| private void galleryIntent() | ||
| { | ||
| Intent intent = new Intent(); | ||
| intent.setType("image/*"); |
There was a problem hiding this comment.
Please extract strings to final static.
| fo.write(bytes.toByteArray()); | ||
| fo.close(); | ||
| } catch (FileNotFoundException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
It is good to show some alert, go back to previous state, etc. if something went wrong.
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
handleAssetSelecting is not used now, but it was responsible for storing asset path in db.
| { | ||
| if (ContextCompat.checkSelfPermission(context, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) { | ||
| if (ActivityCompat.shouldShowRequestPermissionRationale((Activity) context, Manifest.permission.READ_EXTERNAL_STORAGE)) { | ||
| AlertDialog.Builder alertBuilder = new AlertDialog.Builder(context); |
There was a problem hiding this comment.
maybe extract this dialog builder to ( line 32 - 43 ) to separated private method name what this is doing -> showPermissionAlert() ?
| public void onActivityResult(int requestCode, int resultCode, Intent data) { | ||
| super.onActivityResult(requestCode, resultCode, data); | ||
|
|
||
| if (resultCode == Activity.RESULT_OK) { |
There was a problem hiding this comment.
Please check if your ifs match our convention ->
if () {
...
}
No description provided.