feat(graphql): more informative swap quote #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leina05
force-pushed
the
leina/improve_swap_quote
branch
from
4f7f9ed
to
c19e6ba
Compare
fardream
approved these changes
Nov 1, 2022
leina05
force-pushed
the
leina/improve_swap_quote
branch
from
c19e6ba
to
99a2b79
Compare
leina05
commented
Nov 1, 2022
| @@ -59,15 +67,15 @@ input SwapExactInInput { | |||
| coinTypeIn: String! | |||
| amountIn: Float! | |||
| quoteAmountOut: Float! | |||
| slippage: Float | |||
| slippagePct: Float | |||
lidatong
approved these changes
Nov 1, 2022
|
|
||
| if (inReserve === 0 || outReserve === 0) { | ||
| throw new Error("Pool is empty"); | ||
| } | ||
|
|
||
| console.log(parent.coinInfoX.coinType); |
lidatong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.