Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email alerts, with human readable addresses #25

Merged
merged 5 commits into from Oct 15, 2016
Merged

Email alerts, with human readable addresses #25

merged 5 commits into from Oct 15, 2016

Commits on Oct 15, 2016

  1. Remove technical details on alert screen, because it confuses users

    @auxesis
    auxesis committed Oct 15, 2016
    Configuration menu
    Copy the full SHA
    5ee8aab View commit details
    Browse the repository at this point in the history

  2. Make code clearer

    @auxesis
    auxesis committed Oct 15, 2016
    Configuration menu
    Copy the full SHA
    875e066 View commit details
    Browse the repository at this point in the history

  3. Capture more information from user, to build more context around alerts: 

     - Capture the address from the original search
 - Use it in alert emails
 - Do XSS protection where possible
    @auxesis
    auxesis committed Oct 15, 2016
    Configuration menu
    Copy the full SHA
    26dff60 View commit details
    Browse the repository at this point in the history

  4. Update query parameter in tests to trigger alert signup appearing

    @auxesis
    auxesis committed Oct 15, 2016
    Configuration menu
    Copy the full SHA
    ce2c73b View commit details
    Browse the repository at this point in the history

  5. Stop dodgy alerts being created

    @auxesis
    auxesis committed Oct 15, 2016
    Configuration menu
    Copy the full SHA
    2d339be View commit details
    Browse the repository at this point in the history