Skip to content

Fixed a couple things and added some comments and documentation #25

Fixed a couple things and added some comments and documentation

Fixed a couple things and added some comments and documentation #25

Triggered via pull request March 7, 2024 01:43
Status Success
Total duration 41s
Artifacts

lint.yaml

on: pull_request
clippy_check
30s
clippy_check
spell_check
3s
spell_check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 15 warnings
clippy_check
Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
clippy_check
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
spell_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
spell_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
It seems that this Action is executed from the forked repository.
clippy_check
GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See https://github.com/actions-rs/clippy-check/issues/2 for details.
clippy_check: libprotonup/src/github.rs#L30
field assignment outside of initializer for an instance created with Default::default()
clippy_check: libprotonup/src/github.rs#L91
this expression creates a reference which is immediately dereferenced by the compiler
clippy_check: protonup-rs/src/download.rs#L189
length comparison to zero
clippy_check: protonup-rs/src/download.rs#L278
this boolean expression can be simplified
clippy_check: protonup-rs/src/download.rs#L278
this expression creates a reference which is immediately dereferenced by the compiler