Don't install existing apps during quick install unless forced #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
auyer
approved these changes
Mar 7, 2024
Comment on lines
+237
to
+243
| let mut release_list = helper_menus::multiple_select_menu( | ||
| "Select the versions you want to download :", | ||
| release_list, | ||
| ) { | ||
| Ok(release_list) => release_list, | ||
| Err(e) => { | ||
| eprintln!("The tag list could not be processed.\nError: {}", e); | ||
| vec![] | ||
| } | ||
| }; | ||
| ).unwrap_or_else(|e| { | ||
| eprintln!("The tag list could not be processed.\nError: {}", e); | ||
| vec![] | ||
| }); |
There was a problem hiding this comment.
I don't see a reason for this change.
There was a problem hiding this comment.
I'm not certain on this, but I think someone on the Rust discord said unwrap_or_else might be worse for performance because it will run the closure inside of else even if the unwrap is successful, which doesn't happen with a match. I'm not sure if any of that's true however.
There was a problem hiding this comment.
Not that performance would matter in this case anyways. But still, I might revert this back to a match someday.
|
Sorry for taking this long to check your PR. I had way too many work notifications in my github. I will merge it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.