Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change structopt to clap and fix panic #2

Merged
merged 2 commits into from
Feb 9, 2023
Merged

change structopt to clap and fix panic #2

merged 2 commits into from
Feb 9, 2023

Conversation

RaphGL
Copy link
Contributor

@RaphGL RaphGL commented Feb 9, 2023

changes the structopt dependency to clap for cli parsing as structopt is now in maintenance mode and its functionality has already been merged into clap as noted by https://docs.rs/structopt/latest/structopt/#maintenance.

changes the structopt dependency to clap for cli parsing as structopt is
now in maintenance mode and its functionality has already been merged
into clap.
this fixes the panic that happens when the user decided to cancel
instead of proceding with the instructions on the menu
@RaphGL RaphGL changed the title change structopt to clap change structopt to clap and fix panic Feb 9, 2023
@RaphGL
Copy link
Contributor Author

RaphGL commented Feb 9, 2023

I would also suggest looking into cargo clippy there are a bunch of easy fixes there that improve code legibility.

Copy link
Owner

@auyer auyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know about that ! Thanks!

@auyer auyer merged commit fff6cc6 into auyer:main Feb 9, 2023
@auyer auyer added the 💅 Improvement Improvement that are not features label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 Improvement Improvement that are not features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants