Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made app working again #1

Merged
merged 4 commits into from Jul 29, 2018
Merged

Made app working again #1

merged 4 commits into from Jul 29, 2018

Conversation

kerastinell
Copy link

@kerastinell kerastinell commented Jul 18, 2018

I've implemented some fixes without which the app wasn't working properly. Also I added a comment for every commit with the brief explanation of changes.

I guess the only things left to do are to update version name and upload the new APKs.

@Atulin
Copy link

Atulin commented Jul 27, 2018

Honestly, I'd suggest making a fork rather than making a pull request. Doesn;t seem like either of the Derpibooru repos are actively maintained.

@auzbuzzard auzbuzzard merged commit 01d7941 into auzbuzzard:master Jul 29, 2018
@Atulin
Copy link

Atulin commented Jul 31, 2018

Okay, built the app, signed it with a temporaty key, it's working perfectly. Now all it needs is swiping and dark theme 🤣

@kerastinell
Copy link
Author

Thank you for merging my pull request, @auzbuzzard.
About 2 weeks ago I saw some fork on this repository addressing inability to login, but sadly I can't find it anymore. If the issue still persists, please let me know.

@Atulin I will look into what could be done about dark theme and swiping on the weekend, but I can't really promise to deliver it, sorry. The first reason is that I dropped Android developing back in Jellybean (Android 4.3) times and it will not be easy for me to adapt to the new framework. The second reason is my language barrier which kicks in sometimes, making me struggle with writing understandable code comments and expressing my thoughts.

@Atulin
Copy link

Atulin commented Aug 1, 2018

Sure thing, take your time. I'm not in any real hurry since AnimeBoxes added support for Derpibooru API token. No upvoting, favouriting, etc. but I can at least browse all images 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants