Remove error from Router AppGossip (#2238)

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
ava-labs · Oct 31, 2023 · 76d756f · 76d756f
1 parent 5b96789
commit 76d756f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/network/p2p/handler.go b/network/p2p/handler.go
@@ -111,17 +111,15 @@ func (r *responder) AppRequest(ctx context.Context, nodeID ids.NodeID, requestID
 	return r.sender.SendAppResponse(ctx, nodeID, requestID, appResponse)
 }
 
-func (r *responder) AppGossip(ctx context.Context, nodeID ids.NodeID, msg []byte) error {
-	err := r.handler.AppGossip(ctx, nodeID, msg)
-	if err != nil {
+func (r *responder) AppGossip(ctx context.Context, nodeID ids.NodeID, msg []byte) {
+	if err := r.handler.AppGossip(ctx, nodeID, msg); err != nil {
 		r.log.Debug("failed to handle message",
 			zap.Stringer("messageOp", message.AppGossipOp),
 			zap.Stringer("nodeID", nodeID),
 			zap.Uint64("handlerID", r.handlerID),
 			zap.Binary("message", msg),
 		)
 	}
-	return nil
 }
 
 func (r *responder) CrossChainAppRequest(ctx context.Context, chainID ids.ID, requestID uint32, deadline time.Time, request []byte) error {

diff --git a/network/p2p/router.go b/network/p2p/router.go
@@ -256,9 +256,7 @@ func (r *Router) AppGossip(ctx context.Context, nodeID ids.NodeID, gossip []byte
 		return nil
 	}
 
-	if err := handler.AppGossip(ctx, nodeID, parsedMsg); err != nil {
-		return err
-	}
+	handler.AppGossip(ctx, nodeID, parsedMsg)
 
 	handler.metrics.appGossipTime.Observe(float64(time.Since(start)))
 	return nil