Add database fuzzing test (#2214)

.gitignore

@@ -60,3 +60,5 @@ tests/e2e/e2e.test
 tests/upgrade/upgrade.test
 
 vendor
+
+**/testdata

database/corruptabledb/db_test.go

@@ -21,6 +21,14 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		baseDB := memdb.New()
+		db := New(baseDB)
+		test(f, db)
+	}
+}
+
 // TestCorruption tests to make sure corruptabledb wrapper works as expected.
 func TestCorruption(t *testing.T) {
 	key := []byte("hello")

database/encdb/db_test.go

@@ -6,15 +6,18 @@ package encdb
 import (
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
 	"github.com/ava-labs/avalanchego/database"
 	"github.com/ava-labs/avalanchego/database/memdb"
 )
 
+const testPassword = "lol totally a secure password" //nolint:gosec
+
 func TestInterface(t *testing.T) {
-	pw := "lol totally a secure password" // #nosec G101
 	for _, test := range database.Tests {
 		unencryptedDB := memdb.New()
-		db, err := New([]byte(pw), unencryptedDB)
+		db, err := New([]byte(testPassword), unencryptedDB)
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -23,13 +26,23 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		unencryptedDB := memdb.New()
+		db, err := New([]byte(testPassword), unencryptedDB)
+		if err != nil {
+			require.NoError(f, err)
+		}
+		test(f, db)
+	}
+}
+
 func BenchmarkInterface(b *testing.B) {
-	pw := "lol totally a secure password" // #nosec G101
 	for _, size := range database.BenchmarkSizes {
 		keys, values := database.SetupBenchmark(b, size[0], size[1], size[2])
 		for _, bench := range database.Benchmarks {
 			unencryptedDB := memdb.New()
-			db, err := New([]byte(pw), unencryptedDB)
+			db, err := New([]byte(testPassword), unencryptedDB)
 			if err != nil {
 				b.Fatal(err)
 			}

database/leveldb/db_test.go

@@ -8,6 +8,8 @@ import (
 
 	"github.com/prometheus/client_golang/prometheus"
 
+	"github.com/stretchr/testify/require"
+
 	"github.com/ava-labs/avalanchego/database"
 	"github.com/ava-labs/avalanchego/utils/logging"
 )
@@ -30,6 +32,24 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		folder := f.TempDir()
+		db, err := New(folder, nil, logging.NoLog{}, "", prometheus.NewRegistry())
+		if err != nil {
+			require.NoError(f, err)
+		}
+
+		defer db.Close()
+
+		test(f, db)
+
+		// The database may have been closed by the test, so we don't care if it
+		// errors here.
+		_ = db.Close()
+	}
+}
+
 func BenchmarkInterface(b *testing.B) {
 	for _, size := range database.BenchmarkSizes {
 		keys, values := database.SetupBenchmark(b, size[0], size[1], size[2])

database/memdb/db_test.go

@@ -15,6 +15,12 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		test(f, New())
+	}
+}
+
 func BenchmarkInterface(b *testing.B) {
 	for _, size := range database.BenchmarkSizes {
 		keys, values := database.SetupBenchmark(b, size[0], size[1], size[2])

database/meterdb/db_test.go

@@ -8,6 +8,8 @@ import (
 
 	"github.com/prometheus/client_golang/prometheus"
 
+	"github.com/stretchr/testify/require"
+
 	"github.com/ava-labs/avalanchego/database"
 	"github.com/ava-labs/avalanchego/database/memdb"
 )
@@ -24,6 +26,17 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		baseDB := memdb.New()
+		db, err := New("", prometheus.NewRegistry(), baseDB)
+		if err != nil {
+			require.NoError(f, err)
+		}
+		test(f, db)
+	}
+}
+
 func BenchmarkInterface(b *testing.B) {
 	for _, size := range database.BenchmarkSizes {
 		keys, values := database.SetupBenchmark(b, size[0], size[1], size[2])

database/prefixdb/db_test.go

@@ -22,6 +22,12 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		test(f, New([]byte(""), memdb.New()))
+	}
+}
+
 func BenchmarkInterface(b *testing.B) {
 	for _, size := range database.BenchmarkSizes {
 		keys, values := database.SetupBenchmark(b, size[0], size[1], size[2])

database/rpcdb/db_test.go

@@ -79,6 +79,15 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		db := setupDB(f)
+		test(f, db.client)
+
+		db.closeFn()
+	}
+}
+
 func BenchmarkInterface(b *testing.B) {
 	for _, size := range database.BenchmarkSizes {
 		keys, values := database.SetupBenchmark(b, size[0], size[1], size[2])

database/test_database.go

@@ -51,6 +51,10 @@ var Tests = []func(t *testing.T, db Database){
 	TestManySmallConcurrentKVPairBatches,
 }
 
+var FuzzTests = []func(*testing.F, Database){
+	FuzzKeyValue,
+}
+
 // TestSimpleKeyValue tests to make sure that simple Put + Get + Delete + Has
 // calls return the expected values.
 func TestSimpleKeyValue(t *testing.T, db Database) {
@@ -1329,3 +1333,30 @@ func runConcurrentBatches(
 	}
 	return eg.Wait()
 }
+
+func FuzzKeyValue(f *testing.F, db Database) {
+	f.Fuzz(func(t *testing.T, key []byte, value []byte) {
+		require := require.New(t)
+
+		err := db.Put(key, value)
+		require.NoError(err)
+
+		exists, err := db.Has(key)
+		require.NoError(err)
+		require.True(exists)
+
+		gotVal, err := db.Get(key)
+		require.NoError(err)
+		require.True(bytes.Equal(value, gotVal))
+
+		err = db.Delete(key)
+		require.NoError(err)
+
+		exists, err = db.Has(key)
+		require.NoError(err)
+		require.False(exists)
+
+		_, err = db.Get(key)
+		require.ErrorIs(err, ErrNotFound)
+	})
+}

database/versiondb/db_test.go

@@ -18,6 +18,13 @@ func TestInterface(t *testing.T) {
 	}
 }
 
+func FuzzInterface(f *testing.F) {
+	for _, test := range database.FuzzTests {
+		baseDB := memdb.New()
+		test(f, New(baseDB))
+	}
+}
+
 func TestIterate(t *testing.T) {
 	baseDB := memdb.New()
 	db := New(baseDB)