Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pebble database #1394

Closed
danlaine opened this issue Apr 21, 2023 · 0 comments
Closed

Add support for pebble database #1394

danlaine opened this issue Apr 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@danlaine
Copy link
Collaborator

danlaine commented Apr 21, 2023

Context and scope

Right now avalanchego can only use leveldb or an in-memory database (memdb). This ticket is to add support for pebble.

Support should include:

  • Adding a new pebble package underneath the database package
    • Adding a Database type in that package
    • Having that Database type implement database.Database
  • Adding pebble as a valid value for config --db-type
  • Unit tests (See database/leveldb/db_test.go for example)

See hypersdk for example of usage. go-ethereum also uses this package.

Discussion and alternatives

Open questions

@danlaine danlaine added the enhancement New feature or request label Apr 21, 2023
@dboehm-avalabs dboehm-avalabs linked a pull request Apr 27, 2023 that will close this issue
tonyqzhang added a commit that referenced this issue May 16, 2023
tonyqzhang added a commit that referenced this issue May 17, 2023
tonyqzhang added a commit that referenced this issue May 17, 2023
tonyqzhang added a commit that referenced this issue May 17, 2023
tonyqzhang added a commit that referenced this issue May 18, 2023
… start and limit are nil, a nil limit should be treated as a key after all other keys in the db
@StephenButtolph StephenButtolph modified the milestones: v1.10.3, v1.10.4 Jun 15, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.4, v1.10.5 Jun 28, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.5, v1.10.6 Jul 19, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.7, v1.10.8, v1.10.9 Aug 3, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.9, v1.10.10 Aug 25, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.10, v1.10.11 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants