Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keystore ImportUser not checking empty username #223

Closed
3 tasks
Sanghren opened this issue Jun 7, 2020 · 1 comment
Closed
3 tasks

Keystore ImportUser not checking empty username #223

Sanghren opened this issue Jun 7, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Sanghren
Copy link
Contributor

Sanghren commented Jun 7, 2020

Describe the bug
While debugging and fixing a small issue in Slopes (ava-labs/avalanchejs#35), I found out that the Keystore ImportUser function is accepting empty username .

This is not aligned with the rules that are applied in the CreateUser function.

To Reproduce

  • Create a user
  • Export it via exportUser call
  • Try to import it with an empty username
    => You'll see the import is marked as successful .

Expected behavior
Should return an error (See behaviour of CreateUser )

By submitting this issue I agree to the Terms and Conditions of the Developer Accelerator Program.
@Sanghren Sanghren added the bug Something isn't working label Jun 7, 2020
@Sanghren Sanghren mentioned this issue Jun 7, 2020
Merged
@Sanghren
Copy link
Contributor Author

Sanghren commented Jun 8, 2020

Has been merged in #224

@Sanghren Sanghren closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sanghren