Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keystore importUser typo #35

Closed
Sanghren opened this issue Jun 7, 2020 · 1 comment
Closed

keystore importUser typo #35

Sanghren opened this issue Jun 7, 2020 · 1 comment

Comments

@Sanghren
Copy link
Contributor

Sanghren commented Jun 7, 2020

I noticed that there is a typo in the Keystore/api.ts , importUser function.
It leads to the creation of a user with "" as username in Gecko .

Here is the typo (PR open btw)

    importUser = async (username:string, user:string, password:string):Promise<boolean> => {
        let params = {
            "usermame": username, <== HERE
            "user": user,
            "password": password
        };
        return this.callMethod("keystore.importUser", params).then((response:RequestResponseData) => {
            return response.data["result"]["success"];
        });
    }

I'll open an issue (and why not a PR, I want to practice Go :p ) in Gecko, because we should not be able to import an user with an empty username. (There is a specific check in the createUser flow that is missing in the importUser flow)

@collincusce
Copy link
Contributor

Fixed with #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants