defer delegatee rewards until end of validator staking period #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
dhrubabasu
changed the base branch from
dev
to
delegatee-reward-tracking-support
StephenButtolph
approved these changes
Mar 31, 2023
abi87
reviewed
Apr 3, 2023
abi87
reviewed
Apr 3, 2023
| @@ -25,7 +25,7 @@ import ( | |||
| // for the primary network | |||
| func TestAdvanceTimeTxUpdatePrimaryNetworkStakers(t *testing.T) { | |||
| require := require.New(t) | |||
| env := newEnvironment( /*postBanff*/ false) | |||
| env := newEnvironment(false /*=postBanff*/, false /*=postCortina*/) | |||
There was a problem hiding this comment.
IIRC, we are going to change these tests to be postCortina one Cortina activates?
There was a problem hiding this comment.
I think a lot of these tests should be re-vamped. This test is still running pre-Banff...
abi87
approved these changes
Apr 3, 2023
danlaine
approved these changes
Apr 3, 2023
…bs/avalanchego into delegatee-reward-tracking-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Delegatee rewards are often dust amounts which pollute the P-Chain state unnecessarily and make it hard for the validator to spend (case in point: https://explorer-xp.avax.network/tx/3x5sF5zXBto8CHMDR9mFXt5NegymfFpmUxdNTs9TKpPC8TR6a). This PR modifies the delegatee logic so that we consolidate all the delegatee rewards into a single reward utxo distributed at the end of the validator staking period.
How this works
In Cortina, we only provide the validator their delegatee rewards at the end of their validation period. It is awarded in a separate UTXO (first reward utxo is the validation reward, second reward utxo is the total accrued delegatee rewards).
How this was tested