Initialize UptimeCalculator in TestPeer #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
gyuho,
StephenButtolph and
danlaine
as code owners
StephenButtolph
added
bug
|
Can we add a test that fails on dev but passes with this change? |
|
Not sure how easy this would be to make a unit test for... But we could probably make a test for it in the e2e tests (as we already have a full node spun up there to connect to). |
Unit might be a bit annoying since it would increase build time but I think something in e2e sounds reasonable |
StephenButtolph
approved these changes
Apr 3, 2023
dhrubabasu
approved these changes
Apr 3, 2023
patrick-ogrady
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
TestPeer breaks if it handles an inbound ping message because it has a
nilUptimeCalculatorHow this works
Initializes UptimeCalcualtor
How this was tested
CI