Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Logic In Merkle DB History #1310

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Adjust Logic In Merkle DB History #1310

merged 5 commits into from
Apr 11, 2023

Conversation

dboehm-avalabs
Copy link
Contributor

No reason to do a search through the history entries if we know the start root entry is before the end root entry. This will be the case most of time since having the same root in the history multiple times should be pretty rare in normal usage.

No reason to do a search through the history entries if we know the start root entry is before the end root entry.  This will be the case most of time since having the same root in the history multiple times should be pretty rare in normal usage.
@dboehm-avalabs dboehm-avalabs changed the title Adjust Logic In History Adjust Logic In Merkle DB History Apr 10, 2023
x/merkledb/history.go Outdated Show resolved Hide resolved
@patrick-ogrady patrick-ogrady added this to the v1.10.0 (Cortina) milestone Apr 11, 2023
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
@dboehm-avalabs dboehm-avalabs changed the base branch from master to dev April 11, 2023 10:56
@danlaine danlaine merged commit 75eb071 into dev Apr 11, 2023
@danlaine danlaine deleted the ImproveHistoryLogic branch April 11, 2023 18:14
abi87 pushed a commit that referenced this pull request Apr 13, 2023
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants