Cleanup goroutines on health.Stop #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
monitoring
patrick-ogrady
approved these changes
Apr 11, 2023
danlaine
reviewed
Apr 11, 2023
| go func() { | ||
| ticker := time.NewTicker(freq) | ||
| defer ticker.Stop() | ||
| defer func() { |
There was a problem hiding this comment.
yo dawg I heard you like anonymous functions so I put an anonymous function in your anonymous function in an anonymous function so you can func while you func
danlaine
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes a flaky test.
How this works
Stop will now block until all of the goroutines have shut down.
How this was tested
CI + inspection