Cleanup type assertions in the linkedHashmap #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Apr 13, 2023
danlaine
approved these changes
Apr 13, 2023
gyuho
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Just a small code cleanup I noticed when reviewing the locking change.
How this works
Avoids referencing a field of a struct that we just performed a type assertion on... On some places this reduces the number of type assertions... There may technically be a performance hit in some places because it copies the struct into a new var... If there is I don't really care... (and I feel like the compiler should be able to optimize it out if it's smart enough)
How this was tested
CI