Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RewardValidatorTx cleanup #1891

Merged
merged 33 commits into from Sep 19, 2023
Merged

RewardValidatorTx cleanup #1891

merged 33 commits into from Sep 19, 2023

Conversation

abi87
Copy link
Contributor

@abi87 abi87 commented Aug 22, 2023 •
edited

Why this should be merged

It just breaks handling of RewardValidatorTx into smaller pieces, that are more easily upgraded for continuous staking changes.

How this works

Just refactoring

How this was tested

CI

@abi87 abi87 self-assigned this Aug 22, 2023
@abi87 abi87 marked this pull request as ready for review August 22, 2023 20:41
@abi87 abi87 requested a review from dhrubabasu August 22, 2023 21:02
@abi87 abi87 linked an issue Aug 22, 2023 that may be closed by this pull request
Continuous Staking #1426
Open
StephenButtolph
StephenButtolph reviewed Sep 15, 2023
View reviewed changes
vms/platformvm/reward/calculator.go Outdated Show resolved Hide resolved
vms/platformvm/reward/calculator.go Show resolved Hide resolved
vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved
vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved
vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this to the v1.10.11 milestone Sep 19, 2023
@StephenButtolph StephenButtolph merged commit 56816d7 into dev Sep 19, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the reward_tx_refactoring branch September 19, 2023 22:44
@dhrubabasu dhrubabasu mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@ceyonur ceyonur ceyonur approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@danlaine danlaine Awaiting requested review from danlaine danlaine is a code owner

Assignees

@abi87 abi87

Labels
continuous staking
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.11
Development

Successfully merging this pull request may close these issues.

Continuous Staking
4 participants
@abi87 @dhrubabasu @ceyonur @StephenButtolph