Merkledb split node storage into value and intermediate #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
requested review from
danlaine,
darioush,
abi87,
gyuho,
joshua-kim,
hexfusion,
StephenButtolph and
ceyonur
as code owners
danlaine
requested changes
Aug 24, 2023
|
Can we please update the PR description to explain a bit more what this does, how it works, and why we're making this change? |
Co-authored-by: Dan Laine <daniel.laine@avalabs.org> Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
Co-authored-by: Dan Laine <daniel.laine@avalabs.org> Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
Co-authored-by: Dan Laine <daniel.laine@avalabs.org> Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
…s/avalanchego into MerkleDBSplitNodeStorage
…s/avalanchego into MerkleDBSplitNodeStorage
…chego into MerkleDBSplitNodeStorage
…s/avalanchego into MerkleDBSplitNodeStorage
dboehm-avalabs
commented
Aug 28, 2023
x/merkledb/db.go
Outdated
| minRebuildViewSizePerCommit = 1000 | ||
| rebuildViewSizeFractionOfCacheSize = 50 | ||
| minRebuildViewSizePerCommit = 1000 | ||
| rebuildIntermediateDeletionWriteSize = 10 * units.KiB |
There was a problem hiding this comment.
What is a reasonable value for this?
There was a problem hiding this comment.
used here to clear the intermediate node db
danlaine
reviewed
Aug 28, 2023
| @@ -174,6 +174,7 @@ func AtomicClear(readerDB Iteratee, deleterDB KeyValueDeleter) error { | |||
| return AtomicClearPrefix(readerDB, deleterDB, nil) | |||
| } | |||
|
|
|||
| // AtomicClearPrefix deletes from [deleterDB] all keys in [readerDB] that have the given [prefix]. | |||
There was a problem hiding this comment.
Do we want to keep this even though it's currently unused? cc @StephenButtolph
danlaine
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the intermediate nodes(nodes without an associated value) from the value nodes within the database by adding a prefix based on which type of node it is. By splitting them up, we can more easily iterate over key/values. This work allows us to store keys in a more compressed format with full bytes instead of one nibble per byte. Additionally, it splits the cache into two parts to allow for better control over how many value nodes vs intermediate nodes are stored within memory.