e2e: Switch to a default network node count of 2 #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e2e execution is at a new low of 7m (usually ranges between 8-10m). |
hexfusion
reviewed
Aug 25, 2023
| @@ -28,7 +28,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| DefaultNodeCount = 5 | |||
| DefaultNodeCount = 2 // Minimum required to ensure connectivity-based health checks will pass | |||
There was a problem hiding this comment.
even numbers give me the creeps :) How does 3 look?
There was a problem hiding this comment.
I'm not sure how to quantify your discomfort. Is it more than consensus convention? I don't think we're expecting scenarios in a standard e2e job that require more than the minimum number of nodes. And fwiw, this is just the default and doesn't preclude using however many nodes make sense for consensus-focused testing.
StephenButtolph
approved these changes
Aug 26, 2023
darioush
approved these changes
Aug 26, 2023
dhrubabasu
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The current default of 5 nodes requires more resources and slows down test execution on resource-constrained CI workers.
How this works
Default test networks to 2 nodes.
How this was tested
CI