merkledb -- db_test.go cleanup
#1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
requested review from
darioush,
dboehm-avalabs and
StephenButtolph
as code owners
danlaine
commented
Sep 5, 2023
| require.Nil(value) | ||
| } | ||
|
|
||
| func Test_MerkleDB_InsertAndRetrieve(t *testing.T) { |
There was a problem hiding this comment.
Covered by test_database.go
| val, err := db.HealthCheck(context.Background()) | ||
| require.NoError(err) | ||
| require.Nil(val) | ||
| } | ||
|
|
||
| func Test_MerkleDB_Overwrite(t *testing.T) { |
There was a problem hiding this comment.
Covered by test_database.go
| require.Equal([]byte("value1"), value) | ||
| } | ||
|
|
||
| func Test_MerkleDB_Delete(t *testing.T) { |
There was a problem hiding this comment.
Covered by test_database.go
| require.Nil(value) | ||
| } | ||
|
|
||
| func Test_MerkleDB_DeleteMissingKey(t *testing.T) { |
There was a problem hiding this comment.
Covered by test_database.go
| @@ -645,92 +636,126 @@ func TestDatabaseInvalidateChildrenExcept(t *testing.T) { | |||
| func Test_MerkleDB_Random_Insert_Ordering(t *testing.T) { | |||
There was a problem hiding this comment.
Gonna do some more cleanup around the randomized tests in a follow up PR
dboehm-avalabs
approved these changes
Sep 6, 2023
darioush
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes redundant tests and cleans up tests
How this works
See comments
How this was tested
It is tests