Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gossip package to p2p SDK #1958

Merged
merged 20 commits into from Sep 5, 2023
Merged

Add gossip package to p2p SDK #1958

merged 20 commits into from Sep 5, 2023

Conversation

joshua-kim
Copy link
Contributor

Why this should be merged

Adds gossip package, providing primitives to implement a pull-based gossip protocol using bloom filters.

How this works

Adds gossip package to the P2P SDK

How this was tested

Unit tests

@joshua-kim joshua-kim mentioned this pull request Sep 5, 2023
Closed
StephenButtolph
StephenButtolph reviewed Sep 5, 2023
View reviewed changes
network/p2p/gossip/bloom.go Outdated Show resolved Hide resolved
network/p2p/gossip/bloom.go Outdated Show resolved Hide resolved
network/p2p/gossip/gossip.go Outdated Show resolved Hide resolved
network/p2p/gossip/handler.go Outdated Show resolved Hide resolved
network/p2p/gossip/proto/message.proto Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Sep 5, 2023
StephenButtolph
StephenButtolph reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final nits

network/p2p/gossip/bloom.go Outdated Show resolved Hide resolved
network/p2p/gossip/bloom.go Outdated Show resolved Hide resolved
network/p2p/gossip/bloom.go Outdated Show resolved Hide resolved
network/p2p/gossip/bloom.go Outdated Show resolved Hide resolved
network/p2p/gossip/bloom_test.go Outdated Show resolved Hide resolved
network/p2p/gossip/gossip.go Show resolved Hide resolved
network/p2p/gossip/gossip_test.go Outdated Show resolved Hide resolved
network/p2p/gossip/handler.go Outdated Show resolved Hide resolved
network/p2p/gossip/handler.go Show resolved Hide resolved
network/p2p/gossip/handler.go Outdated Show resolved Hide resolved
joshua-kim and others added 13 commits September 5, 2023 15:50
@joshua-kim @StephenButtolph
Update network/p2p/gossip/bloom.go
8fbc3a9 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/bloom.go
6b4466f 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/bloom.go
084e39e 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/bloom_test.go
0055f36 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/gossip_test.go
d01c9ce 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/handler.go
ca99817 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/gossip.go
edaff28 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/gossip.go
6fac89a 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/gossip.go
b2607c2 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim @StephenButtolph
Update network/p2p/gossip/handler.go
889fdb5 
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim
nits
a1f3ba2
@joshua-kim
nit
3c55fb4
@joshua-kim
nit
392d61a
@StephenButtolph StephenButtolph added networking This involves networking sdk This involves SDK tooling or frameworks labels Sep 5, 2023
@StephenButtolph StephenButtolph merged commit 484a72f into dev Sep 5, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the sdk-gossip branch September 5, 2023 21:43
@exdx exdx mentioned this pull request Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@danlaine danlaine Awaiting requested review from danlaine danlaine is a code owner

@gyuho gyuho Awaiting requested review from gyuho gyuho is a code owner

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@joshua-kim joshua-kim

Labels
networking This involves networking sdk This involves SDK tooling or frameworks
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshua-kim @darioush @StephenButtolph