Add sdk gossip handler metrics #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
danlaine and
StephenButtolph
as code owners
joshua-kim
force-pushed
the
gossip-metrics
branch
2 times, most recently
from
8b91477
to
bdec28c
Compare
joshua-kim
force-pushed
the
gossip-metrics
branch
from
bdec28c
to
26032cf
Compare
joshua-kim
commented
Sep 11, 2023
| @@ -34,20 +36,42 @@ func NewGossiper[T any, U GossipableAny[T]]( | |||
| log logging.Logger, | |||
| set Set[U], | |||
| client *p2p.Client, | |||
| ) *Gossiper[T, U] { | |||
| return &Gossiper[T, U]{ | |||
| metrics prometheus.Registerer, | |||
There was a problem hiding this comment.
Making sure people are fine w/ this as our signature. Avalanchego's context exposes a MultiGatherer so we'd be expected to register a prometheus.NewRegistry into the VM's context to use this.
There was a problem hiding this comment.
Yeah this function should be taking in a prometheus.Registerer 👍.
anusha-ctrl
reviewed
Sep 11, 2023
anusha-ctrl
reviewed
Sep 11, 2023
anusha-ctrl
approved these changes
Sep 11, 2023
darioush
approved these changes
Sep 11, 2023
StephenButtolph
approved these changes
Sep 11, 2023
StephenButtolph
added
networking
StephenButtolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
adds metrics to
gossippackageHow this works
adds metrics
How this was tested
n/a