Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup early poll termination logic #2029

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Cleanup early poll termination logic #2029

merged 1 commit into from
Sep 15, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  • Improves (marginally) the performance of the early poll termination logic.
  • Significantly improves the readability of the early poll termination logic.
  • Cleans up the tests for the early poll termination logic (vertices are out blocks are in).

How this works

Mainly just nit cleanup.

How this was tested

  • CI

@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Sep 15, 2023
@StephenButtolph StephenButtolph added testing This primarily focuses on testing cleanup Code quality improvement labels Sep 15, 2023
@StephenButtolph StephenButtolph added the consensus This involves consensus label Sep 15, 2023
@StephenButtolph StephenButtolph merged commit db507cf into dev Sep 15, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the cleanup-poll-termination branch September 15, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@JacobEverly JacobEverly JacobEverly approved these changes

@gyuho gyuho Awaiting requested review from gyuho gyuho is a code owner

Assignees
No one assigned
Labels
cleanup Code quality improvement consensus This involves consensus testing This primarily focuses on testing
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephenButtolph @dhrubabasu @JacobEverly