SDK Push Gossiper implementation #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
force-pushed
the
sdk-push-gossip
branch
3 times, most recently
from
1f83d3b
to
69ea77e
Compare
joshua-kim
commented
Dec 7, 2023
joshua-kim
force-pushed
the
sdk-push-gossip
branch
from
69ea77e
to
956ad64
Compare
joshua-kim
force-pushed
the
refactor-client
branch
2 times, most recently
from
3c26d85
to
02e7588
Compare
joshua-kim
force-pushed
the
sdk-push-gossip
branch
from
956ad64
to
62407ae
Compare
joshua-kim
changed the base branch from
refactor-client
to
push-gossip-feature-branch
joshua-kim
requested review from
gyuho,
hexfusion,
danlaine and
StephenButtolph
as code owners
joshua-kim
force-pushed
the
sdk-push-gossip
branch
2 times, most recently
from
609a244
to
5c99b71
Compare
joshua-kim
requested review from
darioush,
dboehm-avalabs and
abi87
as code owners
joshua-kim
force-pushed
the
sdk-push-gossip
branch
from
5c99b71
to
67f6044
Compare
joshua-kim
force-pushed
the
sdk-push-gossip
branch
2 times, most recently
from
7cbcd12
to
91a777a
Compare
joshua-kim
commented
Dec 13, 2023
joshua-kim
force-pushed
the
sdk-push-gossip
branch
2 times, most recently
from
5bf20f3
to
6ad30af
Compare
joshua-kim
commented
Dec 13, 2023
joshua-kim
force-pushed
the
sdk-push-gossip
branch
from
6ad30af
to
86c13ad
Compare
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
StephenButtolph
approved these changes
Dec 13, 2023
dhrubabasu
approved these changes
Dec 14, 2023
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
approved these changes
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements a push gossiper in the p2p sdk
How this works
Adds an implementation for the client-side logic as well as a server handler
How this was tested
Added unit tests