vms/avm: Add exists bool to mempool Peek
#2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vms/avm/block/builder/builder.go
Outdated
| // Invariant: [mempool.MaxTxSize] < [targetBlockSize]. This guarantees | ||
| // that we will only stop building a block once there are no | ||
| // transactions in the mempool or the block is at least | ||
| // [targetBlockSize - mempool.MaxTxSize] bytes full. | ||
| if tx == nil || len(tx.Bytes()) > remainingSize { | ||
| if !exists && tx == nil || len(tx.Bytes()) > remainingSize { |
There was a problem hiding this comment.
I don't think we should check if tx == nil anymore
There was a problem hiding this comment.
I thought it could still return nil but we do guard against that since we verify the tx first before adding it to the mempool- dropping
StephenButtolph
approved these changes
Dec 11, 2023
patrick-ogrady
approved these changes
Dec 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
abi87
approved these changes
Dec 11, 2023
dhrubabasu
force-pushed
the
add-exists-bool-to-Peek
branch
from
fb32a23
to
0a5c315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Seems odd to use the zero value to determine non-existence, let's be explicit
How this works
Adds an
existsreturn paramHow this was tested
CI