Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vms/platformvm: Add TestBuildBlockDoesNotBuildWithEmptyMempool test #2469

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

Less mocks, more real UTs

How this works

add a UT, remove a UT

How this was tested

CI

@dhrubabasu dhrubabasu added testing This primarily focuses on testing cleanup Code quality improvement labels Dec 11, 2023
@dhrubabasu dhrubabasu added this to the v1.10.18 milestone Dec 11, 2023
@dhrubabasu dhrubabasu self-assigned this Dec 11, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 12, 2023
@dhrubabasu dhrubabasu force-pushed the TestBuildBlockDoesNotBuildWithEmptyMempool branch from 91ad45e to 8df714b Compare December 12, 2023 10:03
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 12, 2023
Merged via the queue into dev with commit 054b5e9 Dec 12, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the TestBuildBlockDoesNotBuildWithEmptyMempool branch December 12, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants