Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P-Chain SDK Gossip #2487

Merged
merged 20 commits into from Dec 23, 2023
Merged

P-Chain SDK Gossip #2487

merged 20 commits into from Dec 23, 2023

Conversation

joshua-kim
Copy link
Contributor

@joshua-kim joshua-kim commented Dec 14, 2023 •
edited

Why this should be merged

Adds SDK transaction gossip to the P-Chain

How this works

See above

This is very similar to #2490, some invariants in the mempool change to be more close to the X-Chain's implementation (see unit test changes for reference).

How this was tested

Pending

@joshua-kim joshua-kim added the networking This involves networking label Dec 14, 2023
@joshua-kim joshua-kim self-assigned this Dec 14, 2023
@joshua-kim joshua-kim changed the title P-Chain SDK Gosisp P-Chain SDK Gossip Dec 14, 2023
@joshua-kim joshua-kim force-pushed the pchain-gossip branch 2 times, most recently from 6fbfa62 to de4477f Compare December 14, 2023 22:01
@joshua-kim joshua-kim marked this pull request as ready for review December 14, 2023 22:08
Base automatically changed from sdk-push-gossip to dev December 14, 2023 23:00
abi87
abi87 reviewed Dec 15, 2023
View reviewed changes
vms/platformvm/vm.go Outdated Show resolved Hide resolved
abi87
abi87 reviewed Dec 15, 2023
View reviewed changes
vms/platformvm/vm.go Outdated Show resolved Hide resolved
abi87
abi87 reviewed Dec 15, 2023
View reviewed changes
vms/platformvm/vm.go Outdated Show resolved Hide resolved
@joshua-kim joshua-kim force-pushed the pchain-gossip branch 2 times, most recently from 569f316 to 6bdde41 Compare December 18, 2023 12:51
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Dec 18, 2023
@StephenButtolph StephenButtolph added the Durango durango fork label Dec 18, 2023
StephenButtolph
StephenButtolph reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to start merging this stuff in - we could probably factor out the test struct exporting into a separate PR and immediately merge that.

StephenButtolph
StephenButtolph reviewed Dec 19, 2023
View reviewed changes
vms/platformvm/network/gossip.go Outdated Show resolved Hide resolved
vms/platformvm/network/gossip.go Outdated Show resolved Hide resolved
vms/platformvm/network/network.go Outdated Show resolved Hide resolved
vms/platformvm/network/gossip.go Outdated Show resolved Hide resolved
vms/platformvm/txs/mempool/mempool.go Outdated Show resolved Hide resolved
vms/platformvm/vm.go Outdated Show resolved Hide resolved
@joshua-kim joshua-kim changed the base branch from dev to gossip-parser December 19, 2023 23:33
@joshua-kim joshua-kim force-pushed the pchain-gossip branch 2 times, most recently from 67e261d to 60325c6 Compare December 20, 2023 00:16
@joshua-kim
fix
dc0e35c 
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim
nit
8d3f143 
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim
nit
b384ca8 
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim
nit
183428a 
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
StephenButtolph reviewed Dec 23, 2023
View reviewed changes
vms/platformvm/vm.go Outdated Show resolved Hide resolved
vms/platformvm/vm.go Outdated Show resolved Hide resolved
vms/platformvm/vm.go Outdated Show resolved Hide resolved
vms/platformvm/txs/tx.go Outdated Show resolved Hide resolved
vms/platformvm/block/builder/builder_test.go Outdated Show resolved Hide resolved
vms/platformvm/config/execution_config_test.go Show resolved Hide resolved
vms/platformvm/network/gossip_test.go Outdated Show resolved Hide resolved
vms/platformvm/network/network.go Show resolved Hide resolved
vms/platformvm/network/network_test.go Show resolved Hide resolved
vms/platformvm/network/network_test.go Show resolved Hide resolved
joshua-kim and others added 4 commits December 22, 2023 22:33
@joshua-kim
nit
911df04 
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@StephenButtolph
address nits
291fcbf
@StephenButtolph
Unexport fields from gossip.BloomFilter
23b9650
@StephenButtolph
Update coreth dependency
6212059
@StephenButtolph StephenButtolph changed the base branch from dev to unexport-bloom-fields December 23, 2023 19:43
@StephenButtolph @dhrubabasu
Update vms/platformvm/network/gossip_test.go
fee9458 
Co-authored-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
dhrubabasu
dhrubabasu approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@dhrubabasu dhrubabasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

Base automatically changed from unexport-bloom-fields to dev December 23, 2023 22:07
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 23, 2023
Merged via the queue into dev with commit 9fb61ab Dec 23, 2023
17 checks passed
@StephenButtolph StephenButtolph deleted the pchain-gossip branch December 23, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abi87 abi87 abi87 left review comments

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@danlaine danlaine Awaiting requested review from danlaine danlaine is a code owner

@gyuho gyuho Awaiting requested review from gyuho

@hexfusion hexfusion Awaiting requested review from hexfusion

@marun marun Awaiting requested review from marun

Assignees

@joshua-kim joshua-kim

Labels
Durango durango fork networking This involves networking
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshua-kim @dhrubabasu @abi87 @StephenButtolph