Only initialize Txs once #2538
Merged
Only initialize Txs once #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
initialize-txs-once
branch
from
5f86f51
to
a6fa28a
Compare
joshua-kim
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
joshua-kim
commented
Dec 22, 2023
StephenButtolph
approved these changes
Dec 22, 2023
JacobEverly
approved these changes
Dec 22, 2023
dhrubabasu
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently transactions can be initialized multiple times throughout their lifecycle which can cause data races.
Related: #2521
How this works
We only now initialize a tx upon creation or when parsing a block.
How this was tested
Unit tests