Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic port peerlist gossip #2603

Merged
merged 14 commits into from
Jan 13, 2024
Merged

Support dynamic port peerlist gossip #2603

merged 14 commits into from
Jan 13, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Jan 11, 2024 •
edited

Why this should be merged

Currently dynamically allocated ports aren't gossiped correctly. The 0 port is gossiped rather than the dynamic port.

How this works

  • Moves NAT logic into the node because it was also broken
  • Only uses the listen port for listening. The gossiped port is the result of parsing the listener address.

How this was tested

  • Manually tested that dynamic IP resolution works as expected
  • CI
  • Added checks during peer handshake and peerlist gossip validation.

@StephenButtolph StephenButtolph added bug Something isn't working networking This involves networking labels Jan 11, 2024
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Jan 11, 2024
@StephenButtolph StephenButtolph self-assigned this Jan 11, 2024
@StephenButtolph StephenButtolph marked this pull request as ready for review January 13, 2024 00:00
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 13, 2024
Merged via the queue into dev with commit a6ee978 Jan 13, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the dynamic-staking-port-fix branch January 13, 2024 22:41
marun pushed a commit that referenced this pull request Jan 17, 2024
@StephenButtolph @marun
Support dynamic port peerlist gossip (#2603)
823c127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

@danlaine danlaine Awaiting requested review from danlaine danlaine is a code owner

@joshua-kim joshua-kim Awaiting requested review from joshua-kim joshua-kim is a code owner

Assignees

@StephenButtolph StephenButtolph

Labels
bug Something isn't working networking This involves networking
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephenButtolph @dhrubabasu @patrick-ogrady