Log critical consensus values during health checks #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
consensus
| @@ -556,6 +556,15 @@ func (t *Transitive) HealthCheck(ctx context.Context) (interface{}, error) { | |||
| t.Ctx.Lock.Lock() | |||
| defer t.Ctx.Lock.Unlock() | |||
|
|
|||
| t.Ctx.Log.Verbo("running health check", | |||
| return json.Marshal(m.keyToValue) | ||
| } | ||
|
|
||
| func (m *BiMap[K, V]) UnmarshalJSON(b []byte) error { |
There was a problem hiding this comment.
Where is the custom unmarshaller used?
There was a problem hiding this comment.
or is this just moreso ensuring if we add marshal, we should also have unmarshal?
There was a problem hiding this comment.
It isn't used. I can remove it if you'd prefer not to have it. Although I felt like implementing json marshal on a normal data structure and not supporting unmarshaling was a bit weird.
patrick-ogrady
approved these changes
Jan 15, 2024
abi87
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds logging of consensus critical values when performing the health check.
How this works
When verbose logging is enabled, we'll now log critical values like outstanding polls, blocked blocks, and other critical values.
How this was tested
Ran a node with verbose logging and made sure the log showed correctly.