Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.uber.org/mock/gomock to v0.4.0 #2618

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

We'll be using some of the new features in #2615. This was made to reduce the diff.

How this works

Bump dependency + re-run mockgen.

How this was tested

CI

@dhrubabasu dhrubabasu added the dependencies This primarily focuses on changing a dependency label Jan 17, 2024
@dhrubabasu dhrubabasu added this to the v1.10.18 milestone Jan 17, 2024
@dhrubabasu dhrubabasu self-assigned this Jan 17, 2024
Copy link
Contributor

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should there be a similar PR for coreth? For otherwise we'll have different versions for mocks in the two repos

Base automatically changed from fix-network-client-mock to dev January 17, 2024 15:49
@dhrubabasu
Copy link
Contributor Author

dhrubabasu commented Jan 17, 2024

LGTM. Should there be a similar PR for coreth? For otherwise we'll have different versions for mocks in the two repos

The mock differences is in mockgen cli functionality, the mocks themselves are effectively identical between versions. When coreth needs it we can port it over easily.

@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 17, 2024
Merged via the queue into dev with commit 0fcc746 Jan 17, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the uber-go-mock-v0.4.0 branch January 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This primarily focuses on changing a dependency
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants