Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always attempt to install mockgen v0.4.0 before execution #2628

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Jan 17, 2024

Why this should be merged

If attempting to run mock.gen.sh with the incorrect version of mockgen, the script can fail unexpectedly.

How this works

Always install the specified version to ensure the script runs with the correct version of mockgen

How this was tested

./scripts/mock.gen.sh

@dhrubabasu dhrubabasu self-assigned this Jan 17, 2024
@dhrubabasu dhrubabasu added the ci This focuses on changes to the CI process label Jan 17, 2024
@dhrubabasu dhrubabasu added this to the v1.10.18 milestone Jan 17, 2024
@dhrubabasu dhrubabasu changed the title Check that mockgen is v0.4.0 before execution Always attempt to install mockgen v0.4.0 before execution Jan 17, 2024
Copy link
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cough nix cough

@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 18, 2024
Merged via the queue into dev with commit d3d1b11 Jan 18, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the check-v0.4.0 branch January 18, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants