Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vms/platformvm: Remove NewRewardValidatorTx from Builder #2676

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

NewRewardValidatorTx is only used in one place, let's move it there.

How this works

pretty straightforward

How this was tested

CI

@dhrubabasu dhrubabasu added the cleanup Code quality improvement label Jan 29, 2024
@dhrubabasu dhrubabasu added this to the v1.10.19 milestone Jan 29, 2024
@dhrubabasu dhrubabasu self-assigned this Jan 29, 2024
@dhrubabasu dhrubabasu marked this pull request as ready for review January 29, 2024 18:29
@StephenButtolph StephenButtolph modified the milestones: v1.10.19, v1.10.20 Jan 29, 2024
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after this imports nit

vms/platformvm/service_test.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 30, 2024
@StephenButtolph StephenButtolph removed this pull request from the merge queue due to a manual request Jan 30, 2024
@StephenButtolph StephenButtolph merged commit aba1336 into master Jan 30, 2024
16 checks passed
@StephenButtolph StephenButtolph deleted the remove-reward-validator-tx-from-builder branch January 30, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants