-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor p2p.PeerTracker
#2701
Merged
Merged
Refactor p2p.PeerTracker
#2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
danlaine,
darioush,
dboehm-avalabs and
joshua-kim
as code owners
February 2, 2024 14:46
darioush
approved these changes
Feb 2, 2024
marun
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
peerInfo
structTrackBandwidth(..., 0)
by explicitly requiring the caller to choose to either callRegisterResponse
orRegisterFailure
GetAnyPeer
(now calledSelectPeer
).RegisterRequest
rather thanSelectPeer
so thatSelectPeer
can be read-only.SelectPeer
andRegisterRequest
. This was done just to maintain the prior behavior... It could be reverted if we wanted to allow potentially sending multiple requests to the highest bandwidth providing peer.bandwidth
is calculated.epsilon
is documented to avoid division by 0... But it was actually being used to prevent marking a node as unresponsive if it responded with a 0 byte message. Previously we should have been using epsilon in both these cases... Now we only need to use it to prevent the division by 0.How this works
For the most part - this is a pure refactor.
How this was tested