Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum golang version to v1.21.7 #2710

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Update minimum golang version to v1.21.7 #2710

merged 6 commits into from
Feb 7, 2024

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Feb 7, 2024

Why this should be merged

go1.22 was released today. Golang only provides security patches for the prior version so we'll update to go1.21.7.

How this works

  • Update to go1.21.7
  • Use the new min and max built-in functions instead of our math.Max and math.Min functions.
  • Use the clear function instead of maps.Clear.
  • Use the new slices pkg instead of /x/exp/slices.
  • Use the new maps pkg instead of /x/exp/maps.
  • Use the new cmp pkg instead of utils.Compare
  • Use context.WithoutCancel instead of utils.Detach

How this was tested

CI

@dhrubabasu dhrubabasu added the dependencies This primarily focuses on changing a dependency label Feb 7, 2024
@dhrubabasu dhrubabasu self-assigned this Feb 7, 2024
@StephenButtolph StephenButtolph added this to the v1.11.0 milestone Feb 7, 2024
@StephenButtolph
Copy link
Contributor

utils.Detach should be replaced with context.WithoutCancel ref: https://go.dev/pkg/context/#WithoutCancel

@StephenButtolph StephenButtolph added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit e248179 Feb 7, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the go1.21.7 branch February 7, 2024 16:56
mboben pushed a commit to mboben/avalanchego that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This primarily focuses on changing a dependency
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants