Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide BLS signature in Handshake message #2730

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Feb 12, 2024

Why this should be merged

This enables peers to enforce that the BLS secret key is known by the peer during the node handshake.

How this works

Signs the claimed IP with the BLS key using the PoP namespace.

How this was tested

  • CI

@StephenButtolph StephenButtolph added networking This involves networking Durango durango fork labels Feb 12, 2024
@StephenButtolph StephenButtolph added this to the v1.11.0 milestone Feb 12, 2024
@StephenButtolph StephenButtolph self-assigned this Feb 12, 2024
@StephenButtolph StephenButtolph marked this pull request as ready for review February 13, 2024 20:51
network/peer/ip.go Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Feb 15, 2024
Merged via the queue into master with commit 6e0837e Feb 15, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the check-p2p-bls-key branch February 15, 2024 00:48
mboben pushed a commit to mboben/avalanchego that referenced this pull request Apr 7, 2024
…s#2730)

Co-authored-by: Chloe <99216251+coffeeavax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Durango durango fork networking This involves networking
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants