Add AppError to Sender interface #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
app-error-sender
branch
from
90c386e
to
87618b7
Compare
joshua-kim
requested review from
danlaine,
StephenButtolph and
gyuho
as code owners
aaronbuchwald
approved these changes
Feb 15, 2024
StephenButtolph
approved these changes
Feb 19, 2024
Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds
SendAppError*functions to the sender interface. Handling for this message already exists but we didn't expose a way for a VM to send these messages previously.How this works
Exposes a new function to send app errors
How this was tested
Tested manually locally