Minimize Signer interface and document Sign #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
the
documentation
dhrubabasu
approved these changes
Feb 15, 2024
marun
approved these changes
Feb 15, 2024
aaronbuchwald
approved these changes
Feb 15, 2024
darioush
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mboben
pushed a commit
to mboben/avalanchego
that referenced
this pull request
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
SignUnsignedon the interface, it just makes it more annoying to implement.How this works
Moves
SignUnsignedinto a static function rather than on the struct.How this was tested
N/A