Sync primary network checkpoints during bootstrapping #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboben
pushed a commit
to mboben/avalanchego
that referenced
this pull request
Apr 7, 2024
Co-authored-by: Stephen <stephen@avalabs.org>
StephenButtolph
commented
Apr 16, 2024
| @@ -446,7 +446,7 @@ func (i *ipTracker) resetBloom() error { | |||
| return err | |||
| } | |||
|
|
|||
| count := max(maxIPEntriesPerValidator*i.gossipableIDs.Len(), minCountEstimate) | |||
| count := max(maxIPEntriesPerNode*i.trackedIDs.Len(), minCountEstimate) | |||
There was a problem hiding this comment.
This is a minor bug fix. Previously we weren't accounting for manuallyTracked nodes correctly in the bloom filter size. This caused frequent bloom filter resets once we were tracking manually tracking significantly more nodes than we were previously.
See added test.
StephenButtolph
added
bug
joshua-kim
reviewed
Apr 16, 2024
| "zGhQDuTyFxZrY3NE3QzBU4v6r8RphEJfMPUgZ2cNHuC7xHbcB" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: missing newline at EOF (or was this done intentionally if it doesn't play nice w/ goembed?)
There was a problem hiding this comment.
This file was auto-generated. If we want to add a newline here, we should do it in the script.
joshua-kim
approved these changes
Apr 16, 2024
dhrubabasu
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is a minimally invasive PR to increase the parallelization of fetching primary network blockchains.
How this works
By including periodic checkpoints of the primary network chains, we can fetch each chain segment in parallel rather than needing to fetch the whole chain serially.
How this was tested