merkledb -- fix hasValue in recordNodeDeleted
#2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
changed the title
hasValue in recordNodeDeletedmerkledb -- fix hasValue in recordNodeDeleted
JacobEverly
approved these changes
Feb 28, 2024
darioush
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
remove, we may call:before
As a result, inside
recordNodeDeleted, we always sethadValueto false, even ifnodeToDeleteused to have a value before we set its value toNothing.This PR fixes that by separately passing in
hadValuetorecordNodeDeleted.