-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable creation of multi-arch docker images #2914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
docker-arm64-image
branch
from
April 4, 2024 16:57
7ad93f4
to
4967749
Compare
marun
changed the title
Build cross-compiled arm64 binary for testing
Enable creation of linux/arm64 images
Apr 4, 2024
marun
force-pushed
the
docker-arm64-image
branch
from
April 5, 2024 16:22
f1199c1
to
608763c
Compare
marun
changed the title
Enable creation of linux/arm64 images
Enable creation of multi-arch docker images
Apr 5, 2024
marun
force-pushed
the
docker-arm64-image
branch
4 times, most recently
from
April 5, 2024 16:39
5752f75
to
67391f3
Compare
marun
force-pushed
the
docker-arm64-image
branch
2 times, most recently
from
April 5, 2024 17:26
c29e8ea
to
f976978
Compare
marun
commented
Apr 5, 2024
marun
force-pushed
the
docker-arm64-image
branch
3 times, most recently
from
April 9, 2024 14:58
d872bbb
to
c810c2e
Compare
marun
commented
Apr 9, 2024
marun
force-pushed
the
docker-arm64-image
branch
3 times, most recently
from
April 10, 2024 09:44
4d2e90d
to
e672f48
Compare
marun
force-pushed
the
docker-arm64-image
branch
2 times, most recently
from
April 10, 2024 09:58
513e7d7
to
6ae6d40
Compare
marun
force-pushed
the
docker-arm64-image
branch
from
April 10, 2024 10:16
6ae6d40
to
d3686fb
Compare
marun
force-pushed
the
docker-arm64-image
branch
from
April 10, 2024 10:39
043aee4
to
d9b6643
Compare
marun
force-pushed
the
docker-arm64-image
branch
from
April 10, 2024 10:40
d9b6643
to
b25070f
Compare
marun
force-pushed
the
docker-arm64-image
branch
from
April 10, 2024 11:43
55c1eb9
to
0fa2ee8
Compare
marun
force-pushed
the
docker-arm64-image
branch
from
April 10, 2024 12:11
f7019c6
to
074ab36
Compare
StephenButtolph
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - images seem to be getting pushed to the dockerhub repo correctly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently images are only published for amd64. To enable testing and development on arm64, this PR:
/avalanchego/build/avalanchego --version
runs without error, indicating that the image and its binary are sane for the intended archThis ended up being a lot more work than I expected - lots of ways to get multiarch builds wrong and the different options (docker build + docker manifest vs docker buildx) each having their own gotchas. The test script ended up being invaluable since at many stages the images were building without error but ending up invalid for the intended arch due to subtle problems with build configuration in the Dockerfile.
TODO:
Image build
job