Refactor MerkleDB.commitChanges
#2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
danlaine,
darioush and
dboehm-avalabs
as code owners
darioush
approved these changes
Apr 8, 2024
JacobEverly
approved these changes
Apr 8, 2024
dboehm-avalabs
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This change is a pure refactor. The goal of this change is to enable easier benchmarking of
commitChanges.This also cleans up some span handling to avoid needing to manually
End()any spans.How this works
Renames
commitChangestocommitViewand introduces two new helpers:applyChangesandcommitChanges.How this was tested